Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./satosa/backend.py:659: # TODO: validate wia scheme using pydantic #141

Closed
Tracked by #113
salvatorelaiso opened this issue Nov 3, 2023 · 3 comments · Fixed by #144
Closed
Tracked by #113

./satosa/backend.py:659: # TODO: validate wia scheme using pydantic #141

salvatorelaiso opened this issue Nov 3, 2023 · 3 comments · Fixed by #144
Assignees
@salvatorelaiso
Labels
enhancement Something improving existing features standardization
Milestone
0.8.0

Comments

@salvatorelaiso
Copy link
Collaborator

No description provided.

@salvatorelaiso salvatorelaiso mentioned this issue Nov 3, 2023
Closed
22 tasks
@salvatorelaiso
Copy link
Collaborator Author

Nella WIA, quale dei due identificatori è corretto per il campo attested_security_context?

In questi due test, vengono utilizzate due chiavi diverse:

eudi-wallet-it-python/pyeudiw/tests/oauth2/test_dpop.py

Line 23 in 9a32ad1

"asc": "https://wallet-provider.example.org/LoA/basic",

eudi-wallet-it-python/pyeudiw/tests/openid4vp/schemas/test_wallet_instance_attestation.py

Line 26 in 9a32ad1

"attested_security_context": "https://wallet-provider.example.org/LoA/basic",

La documentazione riporta la dicitura estesa, ci atteniamo a questa, @peppelinux?

@salvatorelaiso salvatorelaiso self-assigned this Nov 3, 2023
@salvatorelaiso
Copy link
Collaborator Author

Preciso che lo schema Pydantic attuale prevede la dicitura estesa.

eudi-wallet-it-python/pyeudiw/openid4vp/schemas/wallet_instance_attestation.py

Line 49 in 9a32ad1

attested_security_context: HttpUrl

@peppelinux
Copy link
Member

attualmente è attested_security_context ma stiamo migrando a aal qui
italia/eudi-wallet-it-docs#155

dato che con lo sviluppo siamo in una milestone avanzata che guarda alla prossima milestone della documentazione, ti chiedo di allineare aal

@peppelinux peppelinux added this to the 0.8.0 milestone Nov 5, 2023
@peppelinux peppelinux added standardization enhancement Something improving existing features labels Nov 5, 2023
@salvatorelaiso salvatorelaiso mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salvatorelaiso salvatorelaiso

Labels
enhancement Something improving existing features standardization
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

feat: WIA Pydantic validation salvatorelaiso/eudi-wallet-it-python
2 participants
@peppelinux @salvatorelaiso