Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claims carried from the attestation request to the attestation #365

Closed
rohe opened this issue Jul 14, 2024 · 1 comment · Fixed by #430
Closed

Claims carried from the attestation request to the attestation #365

rohe opened this issue Jul 14, 2024 · 1 comment · Fixed by #430
Assignees
Milestone

Comments

@rohe
Copy link
Contributor

rohe commented Jul 14, 2024

According to the spec the body of the Wallet Attestation JWT MUST contain among other claims:

  • authorization_endpoint
  • response_types_supported
  • response_modes_supported
  • vp_formats_supported
  • request_object_signing_alg_values_supported
  • presentation_definition_uri_supported

The only way the wallet provider can have gotten this information is by the attestation request and there the claims above are
not listed as required.
A slight mismatch.
Either the above listed claims should be required in both the request and the assertion or they should be optional.

@grausof
Copy link
Collaborator

grausof commented Oct 1, 2024

Right, you are right. Only vp_formats_supported was already integrated. Fixed by #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants