Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge/nonce endpoint #345

Closed
rohe opened this issue Jul 3, 2024 · 3 comments · Fixed by #348
Closed

Challenge/nonce endpoint #345

rohe opened this issue Jul 3, 2024 · 3 comments · Fixed by #348
Assignees
Milestone

Comments

@rohe
Copy link
Contributor

rohe commented Jul 3, 2024

According to step 3-5 of the "Wallet instance initialization and registration" the Wallet Instance sends a request to the Wallet Provider Backend and receives a one-time challenge.
Which endpoint is used ?
According to the Wallet Providers metadata there is only one endpoint and that is the token endpoint.
Is this a new endpoint not yet documented ?
In the same paragraph it is stated that "This endpoint is compliant with the specification OAuth 2.0 Nonce Endpoint."
Even so it should be part of the Wallet Providers metadata. Demanding that Nonce endpoint discovery must be used according to the specification above is just overkill.

@cmarco0
Copy link
Contributor

cmarco0 commented Jul 3, 2024

According to the text and the specification https://datatracker.ietf.org/doc/draft-demarco-oauth-nonce-endpoint/, the "endpoint" referenced in the statement, "this endpoint is compliant with the OAuth 2.0 Nonce Endpoint specification," is the nonce endpoint and is part of the wallet provider’s backend infrastructure.

@rohe
Copy link
Contributor Author

rohe commented Jul 3, 2024

Yes, but there is no reference to a nonce endpoint in the metadata specified in the Wallet Solution document.
If it doesn't appear in the metadata then the only way to find the endpoint is to send a query without the nonce and then handle the error response returned. This is adding round trips as well as code that could be avoided if the nonce_endpoint just appeared in the wallet provider metadata. There is nothing in the OAuth2.0 Nonce Endpoint specification that prohibits this.

@peppelinux
Copy link
Member

@cmarco0 please do a PR for the definition of the nonce_endpoint metadata parameter, here: https://github.com/peppelinux/draft-demarco-oauth-nonce-endpoint

somethign like

Nonce Issuer Metadata

The Nonce Issuers that uses the Nonce endpoint MUST include in their entity metadata the parameters:

nonce_endpoint. REQUIRED. It MUST be an HTTPs URL indicating the endpoint where the client can request the Nonce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants