Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_importer.rb could probably benefit from using GraphQL #1

Open
bfabio opened this issue Sep 11, 2020 · 6 comments
Open

github_importer.rb could probably benefit from using GraphQL #1

bfabio opened this issue Sep 11, 2020 · 6 comments

Comments

@bfabio
Copy link
Member

bfabio commented Sep 11, 2020

github_importer.rb right now uses the GitHub REST APIs and takes about 2 minutes to complete.

We can probably reduce that time by using the GitHub GraphQL APIs instead, especially in the fetch_teams and fetch_issues methods.

Context. What's github_importer.rb?

github_importer.rb is a script that gets executed periodically and it downloads data from GitHub resulting in the following files getting committed to this repo:

@maurovitale
Copy link
Member

maurovitale commented Oct 16, 2020

Hi @bfabio, I want to try to solve this issue but I need the GITHUB_ACCESS_TOKEN to test the ruby script. Any way to obtain it?

github

@bfabio
Copy link
Member Author

bfabio commented Oct 19, 2020

@maurovitale We need to invite you to the organization, so you can create your own token. cc @sebbalex

@sebbalex
Copy link
Member

Hi @maurovitale I sent you an invitation for the org /italia please accept it. Tnx

@maurovitale
Copy link
Member

Hi @sebbalex, thx for the invitation I accepted and I'll try to solve this issue. I update you soon!

@maurovitale
Copy link
Member

Hi @sebbalex @bfabio , some updates about this problem. I'm using the github explorer to interrogate the graphql github endpoint and it's quite easy to obtain the data. I created a ruby test script on the project (that I will integrate to github_importer.rb, once is finished) to test the requests; to do so, I'm using the 'gqli' lib.

gpql

@bfabio bfabio transferred this issue from italia/developers.italia.it Aug 5, 2021
@bfabio
Copy link
Member Author

bfabio commented Aug 5, 2021

github_importer.rb is now in this repo (italia/developers.italia.it#1045)

@bfabio bfabio changed the title script/github_importer.rb could probably benefit from using GraphQL github_importer.rb could probably benefit from using GraphQL Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants