Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete doesn't clean up ServiceEntries #9

Closed
jwebb49 opened this issue Sep 20, 2019 · 4 comments
Closed

Delete doesn't clean up ServiceEntries #9

jwebb49 opened this issue Sep 20, 2019 · 4 comments
Labels
bug Something isn't working
Milestone
v1.1

Comments

@jwebb49
Copy link
Collaborator

jwebb49 commented Sep 20, 2019

deleting deployments doesn't clean up service entries that are created in the admiral-sync namespace.
@jwebb49 jwebb49 added the hacktoberfest issue open for hackoberfest contribution label Sep 23, 2019
@aattuluri aattuluri changed the title delete doesn't clean up ServiceEntries Delete doesn't clean up ServiceEntries Sep 23, 2019
@aattuluri aattuluri removed the hacktoberfest issue open for hackoberfest contribution label Jan 7, 2020
@aattuluri aattuluri removed their assignment Jan 24, 2020
@martinbaillie
Copy link
Contributor

I've been evaluating Admiral and also noticed this. I feel cleanup is quite a fundamental feature and I'm wondering if anyone is looking at it?

@aattuluri
Copy link
Contributor

@martinbaillie Agreed, there isn't anyone looking at it right now. We can add this to milestone v0.1.

@aattuluri aattuluri added this to the v0.1 milestone Feb 25, 2020
@aattuluri aattuluri modified the milestones: v0.9, v1.0 Apr 6, 2020
@Ultrafenrir
Copy link

+1

@aattuluri aattuluri modified the milestones: v1.0, v1.1 Aug 26, 2020
@aattuluri aattuluri added the bug Something isn't working label Sep 2, 2020
@aattuluri aattuluri mentioned this issue Sep 2, 2020
Closed
@pisto
Copy link

pisto commented Sep 18, 2020

eyeing this

@benchi benchi closed this as completed Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
6 participants
@pisto @martinbaillie @benchi @Ultrafenrir @jwebb49 @aattuluri