add multi glob functionality for inclusion/exclusion

[pajooh]

like

glob([ "src/**/*.js", "!src/**/*.spec.js", "!src/assets/**/*.js" ])

as globs do

[jonathanrdelgado]

Dupe of #36

[sindresorhus]

Check out globby

globs doesn't work correctly as it doesn't handle negates ['*', '!cake'] or filter out duplicates.

I still think this should be built into node-glob though.

[shellscape]

👍 to getting this into node-glob

[intervalia]

This is what I did to get a temporary version to work:

function globArray(patterns, options) {
  var i, list = [];
  if (!Array.isArray(patterns)) {
    patterns = [patterns];
  }

  patterns.forEach(function (pattern) {
    if (pattern[0] === "!") {
      i = list.length-1;
      while( i > -1) {
        if (!minimatch(list[i], pattern)) {
          list.splice(i,1);
        }
        i--;
      }

    }
    else {
      var newList = glob.sync(pattern, options);
      newList.forEach(function(item){
        if (list.indexOf(item)===-1) {
          list.push(item);
        }
      });
    }
  });

  return list;
}

Maybe you could do something similar initially, just to get some level of support.

[alexander-akait]

need 👍

[yocontra]

Every implementation right now just globs everything and then checks the negations afterwards. When dealing with something like this ['**/*.js', '!node_modules/**'] the performance is awful because node-glob is still traversing the node_modules folder and finding results. This needs to be solved in node-glob itself otherwise the perf is going to stay bad. I think we can get a sizable bounty on this if somebody wants to dig in and make a PR for adding this.

[yocontra]

I'm willing to personally put up $500 for a fix for this - not sure if I should do a bountysource or whatever to make that official

[jonathanrdelgado]

@contra in #36, it was stated this would not be added to the package.

Use https://github.com/sindresorhus/globby, keep your $500 and buy yourself a beer.

[UltCombo]

@jonathandelgado globby has inherent perf issues as @contra has already stated.

in #36, it was stated this would not be added to the package.

As far as I can see, @isaacs has only stated that it was "complicated and hard", not that he would never accept a PR nor change his mind in 2 years.

[yocontra]

I've put up some stuff on bountysource for this and a few other issues on node-glob if anyone is interested

[sindresorhus]

https://www.bountysource.com/issues/2761164-add-multi-glob-functionality-for-inclusion-exclusion

[isaacs]

I don't want to add multi-glob functionality, per se, but I do think it's reasonable to add an exclusions set, as a better way to do negative globs.

[isaacs]

See: #115 (comment)