You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
I tried this, but it seems like adding suggestions when one of the lines is deleted is not supported?
When you have a suggestion for multiple lines, those lines will very often include deleted lines, since all changed lines show up as a pair of deleted and added, so this severely limits the usefulness of multiline suggestions.
Any follow up on this? Since a PR is commonly going to have deleted lines, the suggestion feature, whilst convenient & awesome, cannot be used for many PRs.
All changed code does not support multi-line commenting. Even when adding in something as simple as a tab or space to better format previous code, GIT picks this up as a deleted and added line even though compare tools can tell it's minor.
So Unless you are writing brand new code, multi-line commenting is not going to work for you.
I tried this, but it seems like adding suggestions when one of the lines is deleted is not supported?
When you have a suggestion for multiple lines, those lines will very often include deleted lines, since all changed lines show up as a pair of deleted and added, so this severely limits the usefulness of multiline suggestions.
Originally posted by @trygveaa in #1452 (comment)
The text was updated successfully, but these errors were encountered: