Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Active Tile triggers requesting rolls are throwing a JS error #507

Open
devteamplus opened this issue Jul 28, 2024 · 6 comments
Open

Comments

@devteamplus
Copy link

devteamplus commented Jul 28, 2024

Describe the bug
I have created a tile that triggers a roll request - which works. However, the request throws an error in the dnd5e-rolls.js file.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new blank tile
  2. Add an "Enter" trigger to the tile
  3. Add an "Action" to the tile of "Request Roll" by "Triggering Token" of type "Perception" and set it to "Private Roll / Result Hidden" - add Continue if "Any Passed". Also, add a "Chat Message" displayed to "Everyone".
  4. Go back to the map, move a token onto the tile, then observe the results.

Expected behavior
The roll should be requested (which it is) and then have the results displayed to the GM without an error, and display the appropriate chat message if the result is true.

Screenshots
I am adding a screenshot of the roll results in chat, and the console output, as well as a video of the actions. Here is the video link: https://app.screencast.com/xsJpEU7awqvyz
Screenshot 2024-07-28 084544

Please complete as much of the following information as possible:

  • Browser - Chrome
  • Foundry Version - 12.330
  • System Dnd 5e - 3.3.1
  • Module version - Latest compatible with 12.02 (as of this writing)
@devteamplus
Copy link
Author

Any word on this?

@WizardForHire123
Copy link

Any word on this?
@devteamplus
If there was it’d be noted here. The modules are on a rotation this one will get fixed when monk has time. Please be patient he does a lot

@devteamplus
Copy link
Author

Any word on this?
@devteamplus
If there was it’d be noted here. The modules are on a rotation this one will get fixed when monk has time. Please be patient he does a lot

Oh, I get it. Just trying to find out if there is some sort of fix or upcoming revision, so I can properly use Active Tile Triggers. Thanks.

@Crowguard
Copy link
Contributor

Also, @devteamplus. Please include the Foundry version (12.x) & system version (3.3.x) in bug reports. Both of them are updating frequently and currently Monk has no idea which one this became an issue with.

@devteamplus
Copy link
Author

Little bit of an update - something we found out....

The error only seems to get thrown when this box is checked on. Otherwise, the roll request is sent.
Screenshot 2024-08-04 172034

However, as a side note, even with the Roll Mode set to "Private Roll / Results Hidden" or "GM Only Roll", there is a message sent to the players in chat stating that the GM Has Rolled - but it does not show the results to the players.

@devteamplus
Copy link
Author

Regarding my last comment - I know now that the roll message being sent to the players is a core thing. So, ignore that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants