Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 4.3.3 Release #530

Closed
rmorshea opened this issue Aug 12, 2019 · 11 comments
Closed

New 4.3.3 Release #530

rmorshea opened this issue Aug 12, 2019 · 11 comments
Milestone

Comments

@rmorshea
Copy link
Contributor

rmorshea commented Aug 12, 2019

An issue for tracking the progress to a 4.3.3 release.

I have created a 4.3.x branch. In order to get a release, make a PR against this branch with changes that you would like to see included. Be sure to link to the commits your are cherry picking when you make a PR.

@kevin-bates
Copy link
Contributor

Thank you for creating this 4.3.x placeholder. Before I go down the road of adding the contents of #522 (which depends on #341), I see that #341 (and perhaps commits on which it may depend) is marked for milestone 5.0. This implies it contains an API-level change warranting a major release. As a result, I'm hesitant to backport that PR to the 4.3.3 release.

If we find that 5.0 is more warranted, I think that may be more straightforward than cherry-picking specific commits - especially when multi-commit PRs aren't squashed. Of course, I also see milestones of 5.1 that would need to be discarded from 5.0 or we determine they can be included.

Thoughts?

@kevin-bates
Copy link
Contributor

Hi Ryan,

I've gone ahead and composed a PR (#532) that cherry picks only a portion of the commit on which #522 depends. This way, no API or milestone-triggering changes take place. I also included a couple more generic commits relative to versioning and travis.

I hope this is the kind of thing you're looking for relative to getting 4.3.3 (or 4.4.0) released.

Thanks for your help.

@rmorshea
Copy link
Contributor Author

@kevin-bates I'd like to get some feedback from @minrk on this, but my guess is that small releases will be ideal. There's just so much stuff that belongs in a 5.0 release, and I simply don't have the bandwidth to manage that at the moment.

@kevin-bates
Copy link
Contributor

@rmorshea - ping on 4.3.3 tag - thanks.

@rmorshea
Copy link
Contributor Author

@kevin-bates
Copy link
Contributor

@rmorshea - thank you!

Could you please share under what criteria a formal 4.3.3 gets generated? I'd like to get an idea of the timeframe since I may need to create an interim release that requires 4.3.3.dev0 if we're talking about months.

@rmorshea
Copy link
Contributor Author

@kevin-bates in the absence of input from @minrk, @ellisonbg, @Carreau, @SylvainCorlay, @jasongrout or anyone else with more context for the impact a mainline release might have, I don't have a definitive set of criteria. The change seems small enough that it wouldn't be a problem, but it'd be good to get a quick sign-off from a core dev since most Jupyter packages that depend on traitlets don't have their versions pinned.

@rmorshea rmorshea changed the title New 4.3.X Release New 4.3.3 Release Sep 26, 2019
@minrk
Copy link
Member

minrk commented Oct 1, 2019

If it unblocks things, I'm happy to make 4.3.3 with just #532 backported. There's a lot in master for 5.0 and some of it (mainly the new argparse/env string parsing) that needs to be finished before a major release can be made, since it's in an incomplete/unreleasable state right now.

I'm really sorry this has stalled so much.

@kevin-bates
Copy link
Contributor

That would be awesome @minrk, thank you!

@minrk minrk added this to the 4.3.3 milestone Oct 3, 2019
@minrk
Copy link
Member

minrk commented Oct 3, 2019

4.3.3 published from the 4.3.x branch

@minrk minrk closed this as completed Oct 3, 2019
@rmorshea
Copy link
Contributor Author

rmorshea commented Oct 4, 2019

Thanks @minrk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants