Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Asynchronous Comm.on_msg callback #542

Open
duburcqa opened this issue Aug 30, 2020 · 0 comments
Open

[Question] Asynchronous Comm.on_msg callback #542

duburcqa opened this issue Aug 30, 2020 · 0 comments

Comments

@duburcqa
Copy link

duburcqa commented Aug 30, 2020

I'm registering a callback function that forward every messages associated to given registered target to a ZMQ socket (which is a remote server). It works great when the main thread is idle, but if the main thread is busy for some reason, the callback is not call until the main thread finishes its processing. It is a big issue in by case because in practice I'm busy waiting for the server to acknowledge it has received the data...

Here is how I'm registering the callback:

class ZMQIPythonBridge(threading.Thread):
    def __init__(self, comm_url):
        threading.Thread.__init__(self)
        self.zmq_url = zmq_url

    def comm_register(self, comm, msg):
        @comm.on_msg
        def _on_msg(msg):
            data = msg['content']['data']
            self.comm_zmq.send(f"data:{comm.comm_id}:{data}".encode())

        self.comm_zmq.send(f"open:{comm.comm_id}".encode())

    def run(self):
        loop = asyncio.new_event_loop()
        asyncio.set_event_loop(loop)
        ioloop = tornado.ioloop.IOLoop()
        ioloop.make_current()
        context = zmq.Context()
        self.zmq_socket = context.socket(zmq.XREQ)
        self.zmq_socket.connect(self.zmq_url)
        get_ipython().kernel.comm_manager.register_target(
            'my_channel', self.comm_register)
        ioloop.start()

comm_bridge = ZMQIPythonBridge(comm_url)
comm_bridge.start()

Is there a way to still be enable to trigger _on_msg while the main thread is busy wait for the ZMQ socket to acknowledge ? I tried to use a different thread, but as expected in it not changing anything (since the callback mechanism is still handle by the main thread...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant