Jupyter 5.1 changes add_buttons_group

[Sukneet]

Juypter commit jupyter/notebook@af244a6 adds an html span with the label value when calling add_buttons_group. This causes a long name in the toolbar for a lot of extensions. For example, the freeze extension:

[jcb91]

D'oh!

[Sukneet]

The following seems to work
Sukneet@1547b3e

Is the style ok?

[jcb91]

Looks good to me, and the actions have the added bonus that they can be used in the command palette :)

[jcb91]

Opened a PR #1103. There are quite a few other nbextensions that will need similar updates, though. Thanks @Sukneet for reporting & fixing freeze 😄 🙇

[Sukneet]

I fixed the other ones last night. Just need to verify they are all working.

[juhasch]

Thanks for working on this. I am updating n the runtools extension and fixed it there already.

[Sukneet]

I think I got them all (except runtools)
Sukneet@b7aa1bd

[takluyver]

Sorry for this - I thought I had been more careful in making the change than I actually was. Thanks for working on adapting jupyter_contrib_nbextensions to deal with this change.

Once PR #1103 has cleared up the problematically long labels, I hope that some nbextensions will be able to make judicious use of shorter labels on the buttons to make their purpose clearer. E.g. this code in cite2c:

https://github.com/takluyver/cite2c/blob/f310fb00af829664c756404c343d948ab556a2e0/cite2c/nbext/main.js#L296-L302

Produces buttons like this:

[jcb91]

Ok,this should be fixed by #1103 & #1123. As @takluyver notes, though, it might be a good idea to add labels to some of our more ambiguous buttons. We could even make the button labels configurable 🤣

[kenptr]

2to3 and code_prettify still have long labels.