support http delegated content routing protocol #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2022
7 tasks
guseggert
reviewed
Nov 30, 2022
| Protocol: proto.String(), | ||
| Peer: p.Provider.ID, | ||
| Addrs: p.Provider.Addrs, | ||
| Metadata: plb, |
There was a problem hiding this comment.
the Metadata field will be dropped by the client since it is not part of the spec for the Bitswap provider record, do you need this to be accessible by the client?
There was a problem hiding this comment.
for graphsync records, yes - for bitswap, the plb will be nil and the omitempty annotation on line 104 should result in the field not being present
|
@guseggert : do you need to look again to give an approval? |
|
we can merge / deploy to dev to create a test endpoint |
masih
approved these changes
Dec 3, 2022
|
|
||
| h := w.Header() | ||
| h.Add("Access-Control-Allow-Origin", "*") | ||
| h.Add("Access-Control-Allow-Methods", "GET, PUT, OPTIONS") |
Co-authored-by: Gus Eggert <gus@gus.dev>
masih
force-pushed
the
feat/http-delegated-routing
branch
from
46b7fd5
to
22f75df
Compare
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Dec 3, 2022
Deploy support for the new HTTP delegated routing in `dev` environment for testing purposes. See: ipni/indexstar#45
masih
added a commit
to ipni/storetheindex
that referenced
this pull request
Dec 3, 2022
Deploy support for the new HTTP delegated routing in `dev` environment for testing purposes. See: ipni/indexstar#45
masih
added a commit
that referenced
this pull request
Dec 3, 2022
The HTTP delegated routing uses `GET /routing/v1/providers/{CID}` to
lookup CIDs. Translate the CID lookup URI. For the translation
introduced #45 to work correctly, the URI needs to be changed to
`/cid/{CID}`.
Since delegated translator instantiates its own mux, on server handler
mapping the URI prefix needs to be stripped.
masih
added a commit
that referenced
this pull request
Dec 3, 2022
The HTTP delegated routing uses `GET /routing/v1/providers/{CID}` to
lookup CIDs. Translate the CID lookup URI. For the translation
introduced #45 to work correctly, the URI needs to be changed to
`/cid/{CID}`.
Since delegated translator instantiates its own mux, on server handler
mapping the URI prefix needs to be stripped.
|
That's the changes deployed on curl -s https://dev.cid.contact/routing/v1/providers/bafykbzacedzugqdzfjjbd4pgsvwrpkfdpk7rzfrsgwqj2kehxv2ffjy2tlny6 | jq
{
"Providers": [
{
"Protocol": "transport-bitswap",
"ID": "12D3KooWE8yt84RVwW3sFcd6WMjbUdWrZer2YtT4dmtj3dHdahSZ",
"Addrs": [
"/ip4/85.11.148.122/tcp/24001"
],
"Metadata": "gBI="
},
{
"Protocol": "transport-graphsync-filecoinv1",
"ID": "12D3KooWE8yt84RVwW3sFcd6WMjbUdWrZer2YtT4dmtj3dHdahSZ",
"Addrs": [
"/ip4/85.11.148.122/tcp/24001"
],
"Metadata": "kBKjaFBpZWNlQ0lE2CpYKAABgeIDkiAgGFQCpj6i9ZqZIog4XfYgWl6FP9616K18c44shEj+IQdsVmVyaWZpZWREZWFs9G1GYXN0UmV0cmlldmFs9Q=="
}
]
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per ipfs/specs#337
Note, there may be some follow-up extensions to this:
This PR should be enough to provide a compatible implementation to allow interoperability testing.