Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linking/cid: check a previously unused error #68

Merged
merged 1 commit into from
Aug 25, 2020
Merged

linking/cid: check a previously unused error #68

merged 1 commit into from
Aug 25, 2020

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Aug 25, 2020

As spotted by staticcheck. While at it, remove punctuation from another
couple of errors, as per
https://github.com/golang/go/wiki/CodeReviewComments#error-strings:

Error strings should not be capitalized (unless beginning with
proper nouns or acronyms) or end with punctuation, since they
are usually printed following other context.

As spotted by staticcheck. While at it, remove punctuation from another
couple of errors, as per
https://github.com/golang/go/wiki/CodeReviewComments#error-strings:

	Error strings should not be capitalized (unless beginning with
	proper nouns or acronyms) or end with punctuation, since they
	are usually printed following other context.
@warpfork warpfork merged commit 8c54f51 into ipld:master Aug 25, 2020
@mvdan mvdan deleted the unused-error branch August 31, 2020 13:16
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants