Add list and filter commands
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdan
approved these changes
Sep 10, 2021
v2/cmd/car/list.go
Outdated
| } | ||
| return err | ||
| } | ||
| outStream.WriteString(fmt.Sprintf("%s\n", blk.Cid())) |
There was a problem hiding this comment.
Suggested change
| outStream.WriteString(fmt.Sprintf("%s\n", blk.Cid())) | |
| fmt.Fprintf(outStream, "%s\n", blk.Cid()) |
v2/cmd/car/list.go
Outdated
| } | ||
| defer outStream.Close() | ||
|
|
||
| rd, err := icarv1.NewCarReader(r.DataReader()) |
There was a problem hiding this comment.
use https://pkg.go.dev/github.com/ipld/go-car/v2@master#BlockReader? it was written precisely for this :) and it even supports both carv1 and carv2.
v2/cmd/car/filter.go
Outdated
| } | ||
| fmt.Printf("filtering to %d cids\n", len(cidList)) | ||
|
|
||
| cidMap := make(map[cid.Cid]struct{}) |
There was a problem hiding this comment.
consider making parseCIDs build a map directly
There was a problem hiding this comment.
also I wonder if you should at least print a warning on duplicate CIDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example usage: