-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce car explorer (CAR import) #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, switched to ipld-explorer-components@2.1.0 and cleaned up some locale deps.
Things to fix before we merge:
- CAR import does not work when in-memory js-ipfs (
ipfs-core
NPM dependency) is used- see preview at https://bafybeigdetevwemjzlmd3fhmf652fvgfkcek4r3dbs5skhw4eajfc5appa.on.fleek.co/ – console shows
TypeError: iterable[Symbol.iterator] is not a function
error
- see preview at https://bafybeigdetevwemjzlmd3fhmf652fvgfkcek4r3dbs5skhw4eajfc5appa.on.fleek.co/ – console shows
- UX of selecting a CAR:
- when CAR file is selected, nothing happens. Took me a moment to realize I need to click "Explore"
- this is confusing, no need for this additional click – we should open the root CID as soon
dag.import
is finished.
The issue here will be resolved by PR ipfs/ipld-explorer-components#317 |
Changes are now applied based on the review points and feedbacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected now 👍
Let's merge, we can improve UI in separate PR.
Changes
This change introduce the
<IpldCarExplorerForm />
on the explorer.ipld.io.Related PR
ipfs/ipld-explorer-components#313
Verification