Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-delegated-routing cannot properly handle streaming responses #1

Closed
aschmahmann opened this issue May 30, 2022 · 3 comments
Closed

go-delegated-routing cannot properly handle streaming responses #1

aschmahmann opened this issue May 30, 2022 · 3 comments

Comments

@aschmahmann
Copy link
Contributor

go-delegated-routing is unable to process streaming responses. This is due to using the DAG-JSON decoder https://github.com/ipfs/go-delegated-routing/blob/3729ba353037ef1c0d40ba1e87b352acda9c7283/gen/proto/proto_edelweiss.go#L1188 and that decoder not allowing for streaming reads ipld/go-ipld-prime#374.

Once this is fixed in go-delegated-routing (either via some config in go-ipld-prime, or in the code generated by edelweiss) this should be resolved.

cc @ajnavarro @petar
@petar
Copy link

petar commented May 30, 2022

This is addressed in ipld/go-ipld-prime#435 (underway)

This was referenced Jun 10, 2022
Merged
Merged
@petar
Copy link

petar commented Jun 18, 2022

This issue is now resolved by ipfs/go-delegated-routing#26

@aschmahmann
Copy link
Contributor Author

fixed in #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petar @aschmahmann