Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geoip (country flags) column is broken #317

Closed
lidel opened this issue Oct 14, 2022 · 5 comments
Closed

geoip (country flags) column is broken #317

lidel opened this issue Oct 14, 2022 · 5 comments
Assignees
@whizzzkid
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Oct 14, 2022 •
edited
Loading

Country flags no longer show on https://ipfs.github.io/public-gateway-checker/
@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Oct 14, 2022
@galargh galargh moved this to To do in IPFS-GUI (PL EngRes) Oct 14, 2022
@whizzzkid
Copy link
Contributor

This seems to be blocked by: ipfs-shipyard/ipfs-geoip#87 the issue got introduced here: https://github.com/ipfs-shipyard/ipfs-geoip/pull/82/files

@SgtPooki
Copy link
Member

@whizzzkid can we revert the version of geoip we're using so we can resolve this on public gateway checker?

@SgtPooki SgtPooki added exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up effort/hours Estimated to take one or several hours status/ready Ready to be worked labels Oct 17, 2022
@whizzzkid whizzzkid mentioned this issue Oct 18, 2022
Merged
@whizzzkid
Copy link
Contributor

Deployed in #319, fixed ✅

Repository owner moved this from To do to Done in IPFS-GUI (PL EngRes) Oct 21, 2022
@lidel
Copy link
Member Author

lidel commented Oct 21, 2022

@whizzzkid tip: if you include Closes #319 in the description of your PR, then it will automatically close linked issue when PR is merged.

See: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@whizzzkid
Copy link
Contributor

@lidel thanks for the protip. Still getting a hang of GitHub issue management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @SgtPooki @whizzzkid