fix: throw when .proto is empty (#81)

Refuse to compile an empty .proto file
ipfs · Jan 31, 2023 · ed392cb · ed392cb
1 parent a34a908
commit ed392cb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/packages/protons/src/index.ts b/packages/protons/src/index.ts
@@ -655,7 +655,7 @@ export async function generate (source: string, flags: Flags): Promise<void> {
 
   const def = JSON.parse(json)
 
-  for (const [className, classDef] of Object.entries<any>(def.nested)) {
+  for (const [className, classDef] of Object.entries<any>(def.nested ?? {})) {
     for (const [fieldName, fieldDef] of Object.entries<any>(classDef.fields ?? {})) {
       if (fieldDef.keyType == null) {
         continue

diff --git a/packages/protons/test/fixtures/empty.proto b/packages/protons/test/fixtures/empty.proto
diff --git a/packages/protons/test/unsupported.spec.ts b/packages/protons/test/unsupported.spec.ts
@@ -8,4 +8,9 @@ describe('unsupported', () => {
     await expect(generate('test/fixtures/proto2.proto', {})).to.eventually.be.rejected
       .with.property('message').that.contain('"required" fields are not allowed in proto3')
   })
+
+  it('should refuse to generate source from empty definition', async () => {
+    await expect(generate('test/fixtures/empty.proto', {})).to.eventually.be.rejected
+      .with.property('message').that.contain('No top-level messages found in protobuf')
+  })
 })