Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate the pubsub api #9718

Merged
merged 1 commit into from
Mar 15, 2023
Merged

chore: deprecate the pubsub api #9718

merged 1 commit into from
Mar 15, 2023

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Mar 13, 2023 •
edited
Loading

Fixes #9717

@BigLep BigLep requested a review from lidel March 14, 2023 14:44
@BigLep BigLep mentioned this pull request Mar 14, 2023
Open
BigLep
BigLep reviewed Mar 14, 2023
View reviewed changes
Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would be good to get confirmation from @lidel or someone else that this is all that needs to be done.

@BigLep BigLep requested a review from guseggert March 14, 2023 16:33
lidel
lidel requested changes Mar 14, 2023
View reviewed changes
docs/changelogs/v0.19.md Outdated Show resolved Hide resolved
docs/config.md Show resolved Hide resolved
@BigLep
Copy link
Contributor

BigLep commented Mar 14, 2023

@Jorropo : will you be able to incorporate feedback here so we can merge and include in 0.19 release tomorrow?

@BigLep BigLep mentioned this pull request Mar 14, 2023
Closed
@Jorropo
Copy link
Contributor Author

Jorropo commented Mar 15, 2023

Flaky unrelated tests.

@Jorropo Jorropo merged commit 1f5763f into ipfs:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigLep BigLep BigLep left review comments

@lidel lidel lidel requested changes

@guseggert guseggert Awaiting requested review from guseggert

Assignees

@Jorropo Jorropo

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate then Remove /api/v0/pubsub/* RPC API and ipfs pubsub Commands
3 participants
@Jorropo @BigLep @lidel