Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Increase MaxMemory param to use 1/4 of total memory. #9446

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Fix: Increase MaxMemory param to use 1/4 of total memory. #9446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6420307
Increase MaxMemory param to use half of total memory.
ajnavarro Dec 2, 2022
73a2f53
Apply suggestions from code review
ajnavarro Dec 7, 2022
a5175ef
Merge branch 'master' into fix/increase-default-max-memory-on-rm
ajnavarro Dec 7, 2022
41b0c02
Merge branch 'master' into fix/increase-default-max-memory-on-rm
ajnavarro Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/node/libp2p/rcmgr_defaults.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ var noLimitIncrease = rcmgr.BaseLimitIncrease{
// The defaults follow the documentation in docs/config.md.
// Any changes in the logic here should be reflected there.
func createDefaultLimitConfig(cfg config.SwarmConfig) (rcmgr.LimitConfig, error) {
maxMemoryDefaultString := humanize.Bytes(uint64(memory.TotalMemory()) / 8)
maxMemoryDefaultString := humanize.Bytes(uint64(memory.TotalMemory()) / 4)
maxMemoryString := cfg.ResourceMgr.MaxMemory.WithDefault(maxMemoryDefaultString)
maxMemory, err := humanize.ParseBytes(maxMemoryString)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion docs/config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,7 @@ This value is also used to scale the limit on various resources at various scope
when the default limits (discuseed above) are used.
For example, increasing this value will increase the default limit for incoming connections.

Default: `[TOTAL_SYSTEM_MEMORY]/8`
Default: `[TOTAL_SYSTEM_MEMORY]/4`
Type: `optionalBytes`

#### `Swarm.ResourceMgr.MaxFileDescriptors`
Expand Down