Fix: Increase MaxMemory param to use 1/4 of total memory. #9446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was using 1/8 of the total memory. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
changed the title
BigLep
approved these changes
Dec 3, 2022
There was a problem hiding this comment.
@ajnavarro : looks good to me. I think it's also useful to give context in the PR where this is coming from: #9443 (comment)
This should also be added to #9442
9 tasks
|
@BigLep added a comment on the PR description. |
|
Per 2022-12-06 maintainer conversation, we're going to go from half to a quarter of system memory. |
BigLep
approved these changes
Dec 6, 2022
Co-authored-by: Steve Loeppky <biglep@protocol.ai>
ajnavarro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion here: #9443 (comment)
We are going to set the default max memory to 1/2 of the total memory instead of 1/8 to improve the default total inbound connections number, trying to avoid CM errors.
Signed-off-by: Antonio Navarro Perez antnavper@gmail.com