Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for getLocal method in DHT #77

Merged
merged 2 commits into from
Sep 15, 2014
Merged

Test for getLocal method in DHT #77

merged 2 commits into from
Sep 15, 2014

Conversation

llSourcell
Copy link
Contributor

No description provided.

@@ -206,6 +207,11 @@ func TestProvides(t *testing.T) {
t.Fatal(err)
}

_, err = dhts[3].getLocal(u.Key("hello"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while youre at it, verify the value we got back is correct, just for the hell of it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified

@whyrusleeping
Copy link
Member

You should look at using go's code coverage tools for finding out which code really needs testing:
http://blog.golang.org/cover

also, reference issue #59 for things relating to test coverage.

Finding all the glaring red lines of untested code should give you some good ideas of things you could work on in that regard 👍

@whyrusleeping whyrusleeping merged commit 0b5447a into ipfs:master Sep 15, 2014
@btc
Copy link
Contributor

btc commented Sep 15, 2014

@whyrusleeping this is wonderful!

go test -coverprofile=coverage.out 
go tool cover -html=coverage.out

@whyrusleeping
Copy link
Member

Isnt that wonderful? Ive actually built tools like this (yay yacc...) by hand before, and having it so "already done" for me is amazing.

@btc
Copy link
Contributor

btc commented Sep 15, 2014

At some point, I'd like to set up a Jenkins job to generate html coverage output for every push to master. And push the html to S3 or to ipfs over http for viewing.

@whyrusleeping
Copy link
Member

screw s3. lets dogfood this shit.

@btc
Copy link
Contributor

btc commented Sep 15, 2014

I love your attitude! That would make for a great feedback loop. Filed an issue:

#80

@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
@aschmahmann aschmahmann mentioned this pull request Feb 18, 2021
73 tasks
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
feat: disable autonat service when in lowpower mode
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Feb 25, 2022
…onatsvc-lowpower

feat: disable autonat service when in lowpower mode
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…onatsvc-lowpower

feat: disable autonat service when in lowpower mode
laurentsenta pushed a commit to laurentsenta/kubo that referenced this pull request Mar 4, 2022
…onatsvc-lowpower

feat: disable autonat service when in lowpower mode
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants