Fix --ipns-base alias #7659
Merged
Fix --ipns-base alias #7659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
fix/ipns-base-alias
branch
from
488c588
to
ed252d4
Compare
aschmahmann
force-pushed
the
fix/ipns-base-alias
branch
from
ed252d4
to
904ad16
Compare
aschmahmann
commented
Sep 9, 2020
| @@ -1,11 +1,14 @@ | |||
| package keyencode | |||
There was a problem hiding this comment.
Any ideas why code coverage is yelling at me here? Is this just because I removed some lines, or is there something sneaky that I've missed? The report looks pretty weird.
aschmahmann
commented
Sep 9, 2020
| const IPNSKeyFormatOptionName = "ipns-base" | ||
| const ipnsKeyFormatOptionName = "ipns-base" | ||
|
|
||
| var OptionIPNSBase = cmds.StringOption(ipnsKeyFormatOptionName, "Encoding used for keys: Can either be a multibase encoded CID or a base58btc encoded multihash. Takes {b58mh|base36|k|base32|b...}.").WithDefault("base36") |
There was a problem hiding this comment.
@Stebalien Any reason why reusing the same option repeatedly is not recommended?
There was a problem hiding this comment.
No, we do that for some shared options. It should be fine.
Stebalien
approved these changes
Sep 9, 2020
| const IPNSKeyFormatOptionName = "ipns-base" | ||
| const ipnsKeyFormatOptionName = "ipns-base" | ||
|
|
||
| var OptionIPNSBase = cmds.StringOption(ipnsKeyFormatOptionName, "Encoding used for keys: Can either be a multibase encoded CID or a base58btc encoded multihash. Takes {b58mh|base36|k|base32|b...}.").WithDefault("base36") |
There was a problem hiding this comment.
No, we do that for some shared options. It should be fine.
This was referenced Sep 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first refactors
--ipns-baseby putting all the options in one location and then removes the empty alias that was being used.