fix: ipfs pin ls - ignore pins that have errors #7612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't we be returning the error? |
aschmahmann
commented
Aug 20, 2020
core/commands/pin.go
Outdated
| @@ -499,6 +499,9 @@ func pinLsAll(req *cmds.Request, typeStr string, api coreiface.CoreAPI, emit fun | |||
| } | |||
|
|
|||
| for p := range pins { | |||
| if p.Err() != nil { | |||
| continue | |||
There was a problem hiding this comment.
@Stebalien we could return errors but it doesn't look like we have anything to handle those. No idea if anything upstream it's prepared to actually handle the errors.
This might be easier to sneak into the RC since there won't be any surprises, just fewer issues.
There was a problem hiding this comment.
I meant, we could just return an error and abort. IIRC, we'll only get one error anyways.
There was a problem hiding this comment.
That seems like it should work
aschmahmann
force-pushed
the
fix/pin-ls-errors
branch
from
1442599
to
d2c310f
Compare
aschmahmann
commented
Aug 24, 2020
Comment on lines
+502
to
+504
| if p.Err() != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
@Stebalien Is this what you were looking for?
Stebalien
approved these changes
Aug 24, 2020
|
Also relevant ipfs/interface-go-ipfs-core#62. |
aschmahmann
force-pushed
the
fix/pin-ls-errors
branch
from
d2c310f
to
178f581
Compare
aschmahmann
force-pushed
the
fix/pin-ls-errors
branch
from
178f581
to
6871e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.