Upgrade graphsync deps #7598
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ require ( | |
| github.com/ipfs/go-ds-measure v0.1.0 | ||
| github.com/ipfs/go-filestore v0.0.3 | ||
| github.com/ipfs/go-fs-lock v0.0.5 | ||
| github.com/ipfs/go-graphsync v0.1.1 | ||
| github.com/ipfs/go-ipfs-blockstore v0.1.4 | ||
| github.com/ipfs/go-ipfs-chunker v0.0.5 | ||
| github.com/ipfs/go-ipfs-cmds v0.3.0 | ||
|
|
@@ -55,7 +55,7 @@ require ( | |
| github.com/ipfs/go-unixfs v0.2.4 | ||
| github.com/ipfs/go-verifcid v0.0.1 | ||
| github.com/ipfs/interface-go-ipfs-core v0.4.0 | ||
| github.com/ipld/go-car v0.1.1-0.20200429200904-c222d793c339 | ||
|
There was a problem hiding this comment. Is there a release of go-car we can use here? There was a problem hiding this comment. No, this is what I was referring to in my original comment: go-car needs a bit more work for a release. There was a problem hiding this comment. @aschmahmann this is go-car master fwiw, so you are not depending on some random commit. I need to sneak in a particular fix in ( no API changes ), and that's another day or 2 away. There was a problem hiding this comment. So should I be merging this and then we can update go-car later or am I waiting to merge on a go-car release? There was a problem hiding this comment. Let's merge this now, I won't be ready in a reasonable timeframe. |
||
| github.com/jbenet/go-is-domain v1.0.5 | ||
| github.com/jbenet/go-random v0.0.0-20190219211222-123a90aedc0c | ||
| github.com/jbenet/go-temp-err-catcher v0.1.0 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Obviously we need this for now (i.e. until the go-ipfs 0.7.0 release) in order to get things to work, but should we just keep this replace directive here since it's an example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In e.g. go-car it is permanent: https://github.com/ipld/go-car/blob/v0.1.0/car/go.mod#L11
I don't mind either way, we can even remove it right now... ( there are no tests against it )