From 048c1c37b3811c1568f7a6f12ae07d2ba24935ed Mon Sep 17 00:00:00 2001 From: Steven Allen Date: Tue, 12 May 2020 22:30:53 -0700 Subject: [PATCH] fix(mkreleaselog): make robust against running in different working directories 1. Cd into the repo root before running `go list`. 2. Make sure the repo lives in the GOPATH. --- bin/mkreleaselog | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bin/mkreleaselog b/bin/mkreleaselog index 8d3de98cc7c..c30ee7051df 100755 --- a/bin/mkreleaselog +++ b/bin/mkreleaselog @@ -161,7 +161,13 @@ recursive_release_log() { local start="${1:-$(git tag -l | sort -V | grep -v -- '-rc' | grep 'v'| tail -n1)}" local end="${2:-$(git rev-parse HEAD)}" local repo_root="$(git rev-parse --show-toplevel)" - local package="$(go list)" + local package="$(cd "$repo_root" && go list)" + + if ! [[ "${GOPATH}/${package}" != "${repo_root}" ]]; then + echo "This script requires the target package and all dependencies to live in a GOPATH." + return 1 + fi + ( local result=0 local workspace="$(mktemp -d)"