fix: return the shortest, completely resolved path in the resolve command #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
added
the
status/blocked
|
Blocked on ipfs-inactive/interface-js-ipfs-core#385. |
magik6k
approved these changes
Oct 30, 2018
|
Closing in favor of just restoring existing behavior (for now). |
Closed
Stebalien
force-pushed
the
fix/5703
branch
3 times, most recently
from
1f11184
to
4fe3a72
Compare
alanshaw
approved these changes
Feb 19, 2019
Stebalien
removed
the
status/blocked
magik6k
reviewed
Feb 19, 2019
…mand fixes #5703 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
magik6k
approved these changes
Feb 19, 2019
djdv
reviewed
Feb 19, 2019
|
@djdv let'd tackle that in a followup PR (the current code was already doing that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5703
This is a breaking change. We used to return an error if the path didn't end at a CID but, IMO, that's incorrect. We should allow resolution of paths that stop in the middle of an object.