Do not publish public keys extractable from ID #3998
Conversation
Initial implementation for ipfs#3896 The function `peer.ExtractPublicKey()` is part of PR libp2p/go-libp2p-peer#14 cc @whyrusleeping
|
Given the other PR, this looks good to me. I'd definitely want to see some tests though. I would use the offline routing package in the same way that namesys/namesys_test.go does to mock everything out. Obviously we will have to bubble up the changes from go-libp2p-peer once that gets merged too. |
namesys/publisher.go
Outdated
| errorChanSize = 2 // IPNS and public key | ||
| } else { | ||
| errorChanSize = 1 // IPNS only | ||
| } |
There was a problem hiding this comment.
This isn't strictly necessary as over-allocating isn't really an issue (but it's up to you).
There was a problem hiding this comment.
Ok, good point! I'll review this 👍
Makes for a smaller diff, and less code.
|
@JustinDrake could you run the script that gitcop links to set up signing, then rebase this branch on master, that should apply the sign-off to each commit for you. |
See ipfs#3998 Initial implementation for ipfs#3896 The function `peer.ExtractPublicKey()` is part of PR libp2p/go-libp2p-peer#14 cc @whyrusleeping License: MIT Signed-off-by: Justin Drake <drakefjustin@gmail.com>
|
@whyrusleeping For this PR I'm using the in-browser GitHub editor. I just created a new PR at #4020 |
Initial implementation for #3896
The function
peer.ExtractPublicKey()is part of PR libp2p/go-libp2p-peer#14cc @whyrusleeping
License: MIT
Signed-off-by: Justin Drake justin@duo.money