fix(bitswap/message) duplicate entries #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maybebtc lgtm to use a map to avoid dups, but we still need to send an ordered wantlist (unless we change bitswap protocol to communicate priority another way. a normalized priority value may make sense) (maybe this doesn't change ordering on messages, just not seeing it at a glance) |
btc
force-pushed
the
fix/bsmsg-duplicates
branch
from
cc7ec0f
to
20e799e
Compare
added 7 commits
October 27, 2014 21:58
@whyrusleeping noticed this a couple days ago potential long-term fix: prevent duplicate entries in the wantlist by using a map/set and iterating over this data structure on export
implementation will be patched to ensure bitswap messages cannot contain duplicate blocks or keys
A nice invariant for bitswap sessions:
Senders and receivers can trust that messages do not contain
duplicate blocks or duplicate keys. Backing the message with a
map enforces this invariant.
This comes at the cost of O(n) getters.
so there's one less name to think about
comes at the cost of O(n) Blocks() method.
to emphasize idempotence
btc
force-pushed
the
fix/bsmsg-duplicates
branch
from
20e799e
to
91a31a3
Compare
ah missed this detail 💡
yup it does 😞 the
Yeah. Let's add it to the pipeline. For now (alpha), let's keep sorted want list. 💡 How about?
code: |
S+LGTM! just make sure to only send the ordered list :) |
jbenet
added a commit
that referenced
this pull request
Oct 28, 2014
fix(bitswap/message) duplicate entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whyrusleeping @jbenet