-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add closenotify and large timeout to gateway #1980
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
Yep, LGTM. Was thinking that we should have a |
I'm looking at writing that right now, and to get it as efficient as i'd want it, i would need to fork the context lib. (otherwise i need one goroutine per extra context). They (as the go team likes to do) made some methods and interfaces private that would let users efficiently extend their code. |
:c pike!!!!.png On Thu, Nov 19, 2015 at 10:08 PM Jeromy Johnson notifications@github.com
|
I'm considering actually forking it, and making the relevant parts exported. It would allow for more easily exensible contexts for anyone who wants to interop with us (or use that lib) |
im fine with that |
mmmm.... forking time 💃 |
merging, keepalive context stuff can come later. |
add closenotify and large timeout to gateway
gateway requests that fail to resolve would cause goroutines to build up indefinitely.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com