Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to go 1.23 #10486

Merged
merged 2 commits into from
Aug 28, 2024
Merged

chore: upgrade to go 1.23 #10486

merged 2 commits into from
Aug 28, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 20, 2024

GO 1.23 Release Notes: https://tip.golang.org/doc/go1.23

Kubo is not a library, so we can switch to latest version sooner.
This PR aims to see if there are any issues.

@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Aug 20, 2024
This was referenced Aug 20, 2024

replace github.com/ipfs/kubo => ../../

require (
github.com/Kubuxu/gocovmerge v0.0.0-20161216165753-7ecaa51963cd
github.com/golangci/golangci-lint v1.59.1
github.com/golangci/golangci-lint v1.60.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ bumping linter and fixing reported complains made CI green

@lidel lidel marked this pull request as ready for review August 22, 2024 22:42
@lidel lidel requested a review from a team as a code owner August 22, 2024 22:42
Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidel lidel merged commit 2260e35 into master Aug 28, 2024
14 checks passed
@lidel lidel deleted the chore/go1.23 branch August 28, 2024 16:56
lidel added a commit that referenced this pull request Aug 28, 2024
* chore: upgrade to go 1.23

https://tip.golang.org/doc/go1.23

* refactor: golangci-lint v1.60.2

(cherry picked from commit 2260e35)
lidel added a commit to ipfs/distributions that referenced this pull request Aug 28, 2024
lidel added a commit to ipfs/distributions that referenced this pull request Aug 28, 2024
* chore: add Kubo release

* chore: update .tool-versions

ipfs/kubo#10486
@@ -253,4 +253,4 @@ require (
lukechampine.com/blake3 v1.3.0 // indirect
)

go 1.22
go 1.23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to require go 1.23 to build kubo? I think we want to keep this at 1.22.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine to require, we are not a library and https://github.com/ipfs/distributions/blob/master/.tool-versions uses 1.23 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants