Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(daemon): sort listeners #10480

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore(daemon): sort listeners #10480

merged 1 commit into from
Aug 19, 2024

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 14, 2024

Cosmetic UX improvement on top of #10472 based on user feedback when 0 (random port) is used for both TCP and UDP.

Before

Swarm listening on [::1]:37388 (UDP)
Swarm listening on 192.168.50.102:59594 (UDP)
Swarm listening on 192.168.50.102:45445 (TCP)
Swarm listening on [::1]:48490 (UDP)
Swarm listening on 172.17.0.1:45445 (TCP)
Swarm listening on 192.168.50.102:60155 (UDP)
Swarm listening on 172.17.0.1:60155 (UDP)
Swarm listening on 127.0.0.1:57573 (UDP)
Swarm listening on 127.0.0.1:59594 (UDP)
Swarm listening on 172.17.0.1:59594 (UDP)
Swarm listening on [::1]:40151 (TCP)
Swarm listening on [::1]:54080 (UDP)
Swarm listening on 127.0.0.1:45445 (TCP)
Swarm listening on 192.168.50.102:57573 (UDP)
Swarm listening on 172.17.0.1:57573 (UDP)
Swarm listening on 127.0.0.1:60155 (UDP)

After

Swarm listening on 127.0.0.1:38235 (TCP)
Swarm listening on 127.0.0.1:54515 (UDP)
Swarm listening on 127.0.0.1:59476 (UDP)
Swarm listening on 127.0.0.1:60875 (UDP)
Swarm listening on 172.17.0.1:38235 (TCP)
Swarm listening on 172.17.0.1:54515 (UDP)
Swarm listening on 172.17.0.1:59476 (UDP)
Swarm listening on 172.17.0.1:60875 (UDP)
Swarm listening on 192.168.50.102:38235 (TCP)
Swarm listening on 192.168.50.102:54515 (UDP)
Swarm listening on 192.168.50.102:59476 (UDP)
Swarm listening on 192.168.50.102:60875 (UDP)
Swarm listening on [::1]:35542 (UDP)
Swarm listening on [::1]:36413 (UDP)
Swarm listening on [::1]:43063 (TCP)
Swarm listening on [::1]:58548 (UDP)

@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Aug 14, 2024
@lidel lidel requested a review from a team as a code owner August 14, 2024 15:44
@lidel lidel mentioned this pull request Aug 14, 2024
32 tasks
@lidel lidel merged commit 34008b6 into master Aug 19, 2024
16 checks passed
@lidel lidel deleted the chore/sort-listeners branch August 19, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant