Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ipfs init --empty-repo=true the default #9757

Closed
lidel opened this issue Mar 27, 2023 · 0 comments · Fixed by #9758
Closed

Make ipfs init --empty-repo=true the default #9757

lidel opened this issue Mar 27, 2023 · 0 comments · Fixed by #9758
Assignees
@hacdias
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up topic/pinning Topic Pinning (local and remote)

Comments

@lidel
Copy link
Member

lidel commented Mar 27, 2023 •
edited
Loading

This is placeholder issue to switch to ipfs init --empty-repo=true as the default.

Reasons:

  • Main one is UX/DX - unexpected pins on empty repo make it hard to reason about when user used pinning feature
    • Example: Brave uses Kubo RPC for NFT pinning, they had to do extra work to filter out implicit pins that were not related to user data.
  • Future privacy work
    • Implicit pins created unique fingerprint for tracking Kubo users. Sure, we have other vectors like agentVersion, but we are towards improving privacy and cleaning up papercuts like this one is a step in the right direction.
@lidel lidel added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up effort/hours Estimated to take one or several hours topic/pinning Topic Pinning (local and remote) labels Mar 27, 2023
@hacdias hacdias self-assigned this Mar 27, 2023
@lidel lidel mentioned this issue Mar 27, 2023
Closed
@hacdias hacdias mentioned this issue Mar 27, 2023
Merged
@lidel lidel mentioned this issue May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up topic/pinning Topic Pinning (local and remote)
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: make --empty-repo default ipfs/kubo
2 participants
@lidel @hacdias