Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway incorrectly reports NotFound when any error encountered reading UnixFS #9064

Closed
3 tasks done
iand opened this issue Jun 28, 2022 · 0 comments · Fixed by #9126
Closed
3 tasks done

Gateway incorrectly reports NotFound when any error encountered reading UnixFS #9064

iand opened this issue Jun 28, 2022 · 0 comments · Fixed by #9126
Assignees
@lidel
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up topic/gateway Topic gateway
Milestone
Best Effort Track

Comments

@iand
Copy link
Contributor

iand commented Jun 28, 2022

Checklist

Installation method

built from source

Version

Commit 862ce6bb8f6ce24b91ed3dc59e7406faed34f583 (27 June 2022)

Config

No response

Description

When serving a UnixFS file the gateway will return a NotFound error whenever any error was encounted reading the UnixFS dag.

See https://github.com/ipfs/go-ipfs/blob/862ce6bb8f6ce24b91ed3dc59e7406faed34f583/core/corehttp/gateway_handler_unixfs.go#L25

The gateway should distinguish between missing nodes, transient network errors and invalid paths and give appropriate HTTP responses for each

It's possible that #8924 may be related
@iand iand added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jun 28, 2022
@lidel lidel added the topic/gateway Topic gateway label Jul 19, 2022
@lidel lidel moved this to 🥞 Todo in IPFS Shipyard Team Jul 19, 2022
@lidel lidel removed the need/triage Needs initial labeling and prioritization label Jul 19, 2022
@lidel lidel added this to the Best Effort Track milestone Jul 19, 2022
@lidel lidel added the P2 Medium: Good to have, but can wait until someone steps up label Jul 19, 2022
@lidel lidel mentioned this issue Jul 19, 2022
Merged
@lidel lidel self-assigned this Jul 19, 2022
Repository owner moved this from 🥞 Todo to 🎉 Done in IPFS Shipyard Team Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up topic/gateway Topic gateway
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
Development

Successfully merging a pull request may close this issue.

fix(gw): 404 when a valid DAG is missing link ipfs/kubo
2 participants
@iand @lidel