Prometheus ipfs_p2p_peers_total reports number of connections, maybe?

[mrd0ll4r]

Checklist

• I am reporting a documentation issue in this repo, not https://docs.ipfs.io.
• I have searched on the issue tracker for my issue.

Location

https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/metrics.go#L130-L171

Description

From the implementation and from my understanding that you can have multiple connections to the same peer: I'm confused about whether this really reports the number of distinct peers we're connected to, or the number of connections (which potentially counts a single peer multiple times).

[welcome]

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

• "Priority" labels will show how urgent this is for the team.
• "Status" labels will show if this is ready to be worked on, blocked, or in progress.
• "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

[aschmahmann]

Fixed by #8577 such that we're counting peers now