Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting GOFLAGS overrides commit hash #7475

Closed
Stebalien opened this issue Jun 15, 2020 · 1 comment · Fixed by #7477
Closed

Setting GOFLAGS overrides commit hash #7475

Stebalien opened this issue Jun 15, 2020 · 1 comment · Fixed by #7477
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@Stebalien
Copy link
Member

Version information:

v0.5.1

Description:

Setting GOFLAGS on the make command line overrides all the flags we pass to go. This is generally what the user wants. However, the user usually doesn't want to also override the commit hash.

We should have a separate INTERNAL_GOFLAGS variable for flags like this.
@Stebalien Stebalien added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Jun 15, 2020
@Stebalien
Copy link
Member Author

Hm. Alternatively, we can just combine the flags using the override directive.

Stebalien added a commit that referenced this issue Jun 15, 2020
@Stebalien
fix: override GOFLAGS
9ed1e29 
That way we can combine our GOFLAGS with the user specified ones.

This also switches to the new -trimpath build flag for reproducible builds.

fixes #7475
This was referenced Jun 15, 2020
Merged
Closed
aschmahmann pushed a commit that referenced this issue Jul 20, 2020
@Stebalien @aschmahmann
fix: override GOFLAGS
480defa 
That way we can combine our GOFLAGS with the user specified ones.

This also switches to the new -trimpath build flag for reproducible builds.

fixes #7475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: override GOFLAGS ipfs/kubo
1 participant
@Stebalien