Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide simpler core.IPFSNode constructor #658

Closed
btc opened this issue Jan 26, 2015 · 1 comment
Closed

provide simpler core.IPFSNode constructor #658

btc opened this issue Jan 26, 2015 · 1 comment
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@btc
Copy link
Contributor

btc commented Jan 26, 2015

This is a common operation. We should provide a simple alias for it.

    // ~/.go-ipfs
    // IPFS_PATH
    ipfsPath, err := fsrepo.BestKnownPath()
    if err != nil {
        return err
    }
    repo := fsrepo.At(ipfsPath)
    if err := repo.Open(); err != nil {
        return nil
    }

    node, err := core.NewIPFSNode(context.Background(), core.Offline(repo))
    if err != nil {
        return err
    }
@btc btc added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Jan 26, 2015
@whyrusleeping
Copy link
Member

👍 I agree completely

@btc btc self-assigned this Jan 26, 2015
@btc btc removed their assignment Mar 30, 2015
@aschmahmann aschmahmann mentioned this issue Sep 22, 2020
72 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
This reverts commit df4f28c.

Ongoing work is being done in feat/dht-hardening-0.7 and this change isn't quite ready.
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Revert "Peer Diversity in the Routing Table (ipfs#658)"
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants