Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carefully audit and reason through inline CIDs #6011

Open
Stebalien opened this issue Feb 21, 2019 · 0 comments
Open

Carefully audit and reason through inline CIDs #6011

Stebalien opened this issue Feb 21, 2019 · 0 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Inspired by: #6007

I'm worried (well, more than worried, this is happening in #6007) we can accidentally:

  1. Take an "inlined" block.
  2. Mutate it.
  3. Generate a new really big CID using the ID hash function because the original inline block used it.

We may need to change our dagmodifier logic to special-case the identity hash function.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Feb 21, 2019
@Stebalien Stebalien mentioned this issue Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Stebalien