Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let 'ipfs dht findprovs' return more than 20 peers #3839

Closed
victorb opened this issue Mar 28, 2017 · 5 comments
Closed

Let 'ipfs dht findprovs' return more than 20 peers #3839

victorb opened this issue Mar 28, 2017 · 5 comments
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@victorb
Copy link
Member

victorb commented Mar 28, 2017

Version information:

go-ipfs version: 0.4.8-rc1-
Repo version: 5
System version: amd64/darwin
Golang version: go1.8

Type:

Enhancement

Priority:

P5

Description:

Currently when running ipfs dht findprovs it'll continue until a timeout or finding 20 peers. It would be helpful if we could configure the command not return just because it found 20 peers. In addition, would be helpful to be able to configure the amount of time it'll search as well.

Relevant line: https://github.com/ipfs/go-ipfs/blob/cbf8a0cdb4af60c5106fc41d03902272ac72be6e/core/commands/dht.go#L162

@victorb victorb added the kind/enhancement A net-new feature or improvement to an existing feature label Mar 28, 2017
@Kubuxu
Copy link
Member

Kubuxu commented Mar 28, 2017

There is global ipfs option, timeout that causes the command to timeout after some time.

Example: ipfs --timeout=1s dht findprovs /ipfs/QmVZxZgdnZ8h2L7V5bhLsE4CvAmAaGyLjBhFJHYigPE9X1

@ghost
Copy link

ghost commented Mar 29, 2017

Needs to be documented -- it's not in ipfs --help

@faddat
Copy link

faddat commented Apr 2, 2017

is this what one would use to identify the peers serving a given file?

@Kubuxu
Copy link
Member

Kubuxu commented Apr 17, 2017

Yes findprovs can be used for that.

@Kubuxu
Copy link
Member

Kubuxu commented Apr 17, 2017

It should be very easy to do, just making https://github.com/ipfs/go-ipfs/blob/master/core/commands/dht.go#L162 a CLI parameter and adding some tests for it.

@Kubuxu Kubuxu added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue labels Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants