Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very weird panic during linux CI run #3710

Closed
whyrusleeping opened this issue Feb 20, 2017 · 3 comments · Fixed by #3723
Closed

Very weird panic during linux CI run #3710

whyrusleeping opened this issue Feb 20, 2017 · 3 comments · Fixed by #3723
Assignees
@Kubuxu
Labels
kind/bug A bug in existing code (including security flaws) RFM
Milestone
Ipfs 0.4.7

Comments

@whyrusleeping
Copy link
Member

Scroll to the bottom of this travis CI log: https://s3.amazonaws.com/archive.travis-ci.org/jobs/202531197/log.txt
@Kubuxu
Copy link
Member

Kubuxu commented Feb 20, 2017

I've seen it once before, it seems that during exiting due to wrong CLI args some other goroutine in background tries to attach process and it panics.

@whyrusleeping
Copy link
Member Author

Ah, looks like we need to move the http gateway creation stuff to start after everything else has begun

@whyrusleeping whyrusleeping added help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) labels Feb 20, 2017
@whyrusleeping
Copy link
Member Author

Should be as simple as moving the gateway setup stuff here https://github.com/ipfs/go-ipfs/blob/master/cmd/ipfs/daemon.go#L379 down to right before the "Daemon is ready" message. This shouldnt mess with any of the printed output AFAIK.

@Kubuxu Kubuxu mentioned this issue Feb 24, 2017
Merged
@Kubuxu Kubuxu self-assigned this Feb 24, 2017
@Kubuxu Kubuxu added the status/in-progress In progress label Feb 24, 2017
@whyrusleeping whyrusleeping added this to the Ipfs 0.4.7 milestone Feb 24, 2017
@Kubuxu Kubuxu added RFM and removed status/in-progress In progress help wanted Seeking public contribution on this issue labels Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kubuxu Kubuxu

Labels
kind/bug A bug in existing code (including security flaws) RFM
Projects
None yet
Milestone
Ipfs 0.4.7
Development

Successfully merging a pull request may close this issue.

daemon: move gateway start to latter ipfs/kubo
2 participants
@whyrusleeping @Kubuxu