Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate add/pin/gc locking #3514

Open
3 tasks
ghost opened this issue Dec 16, 2016 · 1 comment
Open
3 tasks

Investigate add/pin/gc locking #3514

ghost opened this issue Dec 16, 2016 · 1 comment
Labels
help wanted Seeking public contribution on this issue kind/test Testing work topic/commands:add Topic commands:add topic/repo Topic repo

Comments

@ghost
Copy link

ghost commented Dec 16, 2016

While looking into #3470 and #3436, I found that the locks around adding/pinning/GC look really wonky and inconsistent.

This issue is a reminder that we need to:

  • Look very closely at which locks are in play
  • Document in detail how these locks work
  • Write stress tests which make sure we don't end deadlock ourselves
@ghost ghost added topic/commands:add Topic commands:add topic/repo Topic repo kind/test Testing work labels Dec 16, 2016
@hsanjuan
Copy link
Contributor

Yes, I've also noticed weird things like pin ls being blocked if a pin add is ongoing. I'm going to be looking more closely into this in the near future.

@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/test Testing work topic/commands:add Topic commands:add topic/repo Topic repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsanjuan @whyrusleeping