-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dht query early exit bug #308
Labels
kind/bug
A bug in existing code (including security flaws)
Comments
Oh, not so good. so this is a problem of specifying to the query runner when a query is done, correct? |
yeah, basically it assumes that its done as soon as it receives a single 'successful' response. |
@whyrusleeping is this still a problem? |
This has been addressed and we should be able to close this one out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed a slight bug that probably hasnt caused any issues yet, but nonetheless, i beleive its a bug.
While running dhthell tests, i had one node do a 'put key val' and was presented the following messages:
Which up until now, i had been ignoring, but when i went to investigate what caused them, i found that as soon as a single 'PUT' query finished, we cancelled the context for all of them, causing their response handlers to be removed. Which, if we had any put queries that hadnt been run yet, would have caused our value to not have been propogated correctly (fortunately, our PUT operations all get sent out at the same time).
The text was updated successfully, but these errors were encountered: