Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No API to know if server is shutting down #1023

Closed
torarnv opened this issue Apr 6, 2015 · 2 comments
Closed

No API to know if server is shutting down #1023

torarnv opened this issue Apr 6, 2015 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/api Topic api

Comments

@torarnv
Copy link
Contributor

torarnv commented Apr 6, 2015

Results in ipfs/ipfs-webui#28
@whyrusleeping
Copy link
Member

Well, we do have a way of knowing if the server is shutting down, the master context will signal everyone who has registered to know. The issue here is that braintree/manners doesnt respect contexts.

@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) topic/gateway Topic gateway labels Apr 6, 2015
@ghost ghost added topic/api Topic api and removed topic/gateway Topic gateway labels Sep 2, 2016
@Stebalien
Copy link
Member

Go-ipfs will now immediately stop listening on the API when shutting down. I'd say that's a pretty decent signal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) topic/api Topic api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@torarnv @Stebalien @whyrusleeping