Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS_PATH is no longer used after 1.x #497

Closed
hacdias opened this issue Apr 17, 2020 · 0 comments
Closed

IPFS_PATH is no longer used after 1.x #497

hacdias opened this issue Apr 17, 2020 · 0 comments

Comments

@hacdias
Copy link
Member

hacdias commented Apr 17, 2020

While finally trying to upgrade IPFS Desktop to CTL 3.x, I noticed every test where we were setting the IPFS_PATH env var were failing and then looked at the code.

Before 1.0, ipfsd-ctl was using the parent process IPFS_PATH variable if it was set:

this._env = Object.assign({}, process.env, this.opts.env)
// ...
get env () {
    return this.path ? Object.assign({}, this._env, { IPFS_PATH: this.path }) : this._env
}

Right now, the only place where that variable is mentioned doesn't seem to use the parent's process:

this.env = merge({ IPFS_PATH: this.path }, this.opts.env)

/cc @hugomrdias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant