fix: add namesys pubsub option #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For implementing the tests for
IPNS over Pubsubonjs-ipfsusing atype: procdaemon, we need to have the--enable-namesys-pubsuboption properly handled.Moreover, I cannot add a test for it, similar to the one already available for
--enable-pubsub-experiment, as it is not available in the last released version ofjs-ipfs. Once this is merged, I will create an Issue for adding those tests and whenIPNS over PubsubPR is merged and released, I will get back here for adding the proper test.