feat/awesome dag-pb #625

daviddias · 2016-11-24T20:41:52Z

core
http
cli

facing some issues introduced with new swarms API, will focus on finishing this #600 first

feat(swarm): update swarm.peers to new api

daviddias · 2016-11-24T21:03:26Z

Finished #600

Now only a test missing in core:

  1) core --both bitswap connections fetches a remote file 2 peers:
     Error: timeout of 80000ms exceeded. Ensure the done() callback is being called in this test.

Which fails because ipfs.files.add never finishes for a file. Investigating

daviddias · 2016-11-25T10:54:14Z

Only 6 tests missing (really only 4, because 2 of them are the same thing, just api online and offline)

bootstrap

I didn't even touch any of this, trying to figure out what happened:

1) cli --all bootstrap api running add another bootstrap node:
     Command failed: /Users/ground-control/code/js-ipfs/src/cli/bin.js bootstrap add /ip4/111.111.111.111/tcp/1001/ipfs/QmcyFFKfLDGJKwufn2GeitxvhricsBQyNKTkrD14psikoD
/Users/ground-control/code/js-ipfs/src/cli/commands/bootstrap/add.js:23
          throw err
          ^
2) cli --all bootstrap api running rm a bootstrap node:
     Command failed: /Users/ground-control/code/js-ipfs/src/cli/bin.js bootstrap rm /ip4/111.111.111.111/tcp/1001/ipfs/QmcyFFKfLDGJKwufn2GeitxvhricsBQyNKTkrD14psikoD
/Users/ground-control/code/js-ipfs/src/cli/commands/bootstrap/rm.js:22
          throw err

patch addLink and rmLink

3) cli --all object api offline patch add-link:
     Command failed: /Users/ground-control/code/js-ipfs/src/cli/bin.js object patch add-link QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zR1n foo QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn
/Users/ground-control/code/js-ipfs/node_modules/multihashes/lib/index.js:21
    throw new Error('must be passed a buffer');

4) cli --all object api offline patch rm-link:
     Error: Command failed: /Users/ground-control/code/js-ipfs/src/cli/bin.js object patch rm-link QmdVHE8fUD6FLNLugtNxqDFyhaCgdob372hs6BYEe75VAK foo
src/cli/bin.js object patch rm-link <root> <link>

Options:
  --help  Show help  [boolean]

A link requires a multihash to point to

@dignifiedquire @haadcode @victorbjelkholm can I start getting a CR while I try to figure out these ones? So that we have it on time for tomorrow :)

dignifiedquire · 2016-11-25T11:15:50Z

src/cli/commands/object/get.js

+        argv.key,
+        { enc: 'base58' },
+        cb)
+    ], (err, node) => {


please refrain from these cosmetic changes, I will change it back in the next commit any way and it makes it harder to see the relevant changes.

fair point! :)

dignifiedquire · 2016-11-25T11:17:07Z

src/cli/commands/object/patch/add-link.js

+          }
+        )
+      }
+    ], (err) => {


this is a lot more complex and harder to read then before :(

It is also my attempt of trying to break each step by parts so that I can debug what is happening

dignifiedquire · 2016-11-25T11:18:34Z

src/core/components/object.js

-              return link.name !== linkRef.name
-            }
-
-            return !link.hash.equals(linkRef.hash)


what about all the code above, why can we suddenly drop it?

It was duplicated logic, the addLink/rmLink operations on DAGNode are more complete now.

dignifiedquire · 2016-11-25T11:20:31Z

src/http-api/resources/object.js

+          },
+          (cb) => {
+            cb(null, linkedObj.multihash)
+          }


No need to use parallel with callbacks anymore

daviddias · 2016-11-25T14:12:38Z

Now passing tests \o/ with the Caveat that Bootstrap add and rm fail, since it changed in js-ipfs-api and without having it standardized -- ipfs-inactive/interface-js-ipfs-core#97 --, it is hard to follow changes.

daviddias · 2016-11-25T15:15:28Z

package.json

@@ -18,7 +18,7 @@
    "npm": ">=3.0.0"
  },
  "scripts": {
-    "lint": "aegir-lint",
+    "lint": "eslint -c node_modules/aegir/config/eslintrc.yml src test",


linting is fine, it is just aegir-lint that is being mysterious. This is a known problem by @dignifiedquire, needs to be more investigated.

thanks @victorbjelkholm for the tip! :)

thanks, but lets try to not actually merge this code, will see if I can figure this out on the aegir side

Q. Why did it pass with eslint -c node_modules/aegir/config/eslintrc.yml src test?

A. It did not lint examples

Q. Why does aegir fail silently?

A. An eslint plugin being used in the examples folder: https://github.com/ipfs/js-ipfs/blob/master/examples/bundle-webpack/.eslintrc#L9 was missing, which resulted in an exit from eslint. Running eslint on the command line will print a custom error message for this, which does not happen when using gulp-eslint.

Q. Why does linting still fail?

A. Because the examples were never properly fixed.

daviddias · 2016-11-25T17:19:49Z

package.json

@@ -54,6 +54,7 @@
    "buffer-loader": "0.0.1",
    "chai": "^3.5.0",
    "detect-node": "^2.0.3",
+    "eslint-plugin-react": "^6.7.1",


oh, it was because of the added example? 💥

daviddias · 2016-11-25T17:49:09Z

Tests suddenly started failing on Travis :( will try to investigate during my flight, locally and on circle is fine :S

daviddias · 2016-11-25T18:09:17Z

Found the issue, protocol-buffers was updated with a breaking change

https://github.com/ipfs/js-ipfs-unixfs/blob/master/src/index.js#L54

type became an object: TYPE: { value: 2, options: {} } instead of just the value

Will update once I land and get internet again :)

@mafintosh was that breaking change on the last release intentional?

daviddias · 2016-11-26T01:34:23Z

CI is green again with new js-ipfs-unixfs released :)

mafintosh · 2016-11-26T04:49:03Z

@diasdavid nope wasnt on purpose :( what broke in the latest release?

mafintosh · 2016-11-26T05:05:19Z

found and fixed the regression. sry about that.

daviddias · 2016-11-26T09:59:47Z

thank you @mafintosh <3

daviddias added 2 commits November 24, 2016 19:21

chore: update deps

12325a2

feat(core): migrate to awesome dag-pb

db550a1

daviddias added the status/in-progress In progress label Nov 24, 2016

dignifiedquire and others added 3 commits November 24, 2016 20:52

feat(swarm): update swarm.peers to new api

265a77a

chore: update deps

3fa1438

Merge pull request #600 from ipfs/new-swarm-peers

1132f33

feat(swarm): update swarm.peers to new api

feat(http): migrate to awesome dag-pb

ca9935f

daviddias added the needs review label Nov 25, 2016

daviddias mentioned this pull request Nov 25, 2016

Awesome dagPB.DAGNode API #617

Closed

dignifiedquire suggested changes Nov 25, 2016

View reviewed changes

daviddias force-pushed the feat/awesome-dag-pb branch from 0414b5e to 5ff5cf9 Compare November 25, 2016 11:29

feat(cli): migrate to awesome-dag-pb

3bb3ba8

daviddias force-pushed the feat/awesome-dag-pb branch from 5ff5cf9 to 3bb3ba8 Compare November 25, 2016 11:29

daviddias removed the needs review label Nov 25, 2016

fix: apply CR

698f708

daviddias force-pushed the feat/awesome-dag-pb branch from e06f7dc to 698f708 Compare November 25, 2016 13:51

fix: addLink and rmLink

7fad4d8

daviddias force-pushed the feat/awesome-dag-pb branch from 918893d to 7fad4d8 Compare November 25, 2016 14:16

fix(lint): use eslint directly

443dd9e

daviddias commented Nov 25, 2016

View reviewed changes

dignifiedquire mentioned this pull request Nov 25, 2016

Missing output from lint command (and possible others) ipfs/aegir#67

Closed

daviddias commented Nov 25, 2016

View reviewed changes

daviddias force-pushed the feat/awesome-dag-pb branch from b68c43a to 2e59227 Compare November 25, 2016 17:26

fix(lint): install missing plugin

20e3d2e

daviddias force-pushed the feat/awesome-dag-pb branch from 2e59227 to 20e3d2e Compare November 25, 2016 17:34

daviddias merged commit 1eb664f into master Nov 26, 2016

daviddias deleted the feat/awesome-dag-pb branch November 26, 2016 01:34

daviddias removed the status/in-progress In progress label Nov 26, 2016

daviddias mentioned this pull request Nov 26, 2016

errors during jsipfs init #629

Closed

rtpro mentioned this pull request Nov 27, 2023

[Snyk] Fix for 16 vulnerabilities rtpro/js-ipfs#69

Open

This was referenced Nov 27, 2023

[Snyk] Fix for 6 vulnerabilities thexdesk/js-ipfs#34

Open

[Snyk] Fix for 6 vulnerabilities thexdesk/js-ipfs#35

Open

This was referenced Nov 28, 2023

[Snyk] Fix for 6 vulnerabilities awaisab172/js-ipfs#58

Open

[Snyk] Fix for 16 vulnerabilities awaisab172/js-ipfs#59

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat/awesome dag-pb #625

feat/awesome dag-pb #625

daviddias commented Nov 24, 2016 •

edited

Loading

daviddias commented Nov 24, 2016

daviddias commented Nov 25, 2016

dignifiedquire Nov 25, 2016

daviddias Nov 25, 2016

dignifiedquire Nov 25, 2016

daviddias Nov 25, 2016

dignifiedquire Nov 25, 2016

daviddias Nov 25, 2016

dignifiedquire Nov 25, 2016

daviddias commented Nov 25, 2016

daviddias Nov 25, 2016

dignifiedquire Nov 25, 2016

dignifiedquire Nov 25, 2016

daviddias Nov 25, 2016

dignifiedquire Nov 25, 2016

daviddias commented Nov 25, 2016

daviddias commented Nov 25, 2016 •

edited

Loading

daviddias commented Nov 26, 2016

mafintosh commented Nov 26, 2016

mafintosh commented Nov 26, 2016

daviddias commented Nov 26, 2016

feat/awesome dag-pb #625

feat/awesome dag-pb #625

Conversation

daviddias commented Nov 24, 2016 • edited Loading

daviddias commented Nov 24, 2016

daviddias commented Nov 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias commented Nov 25, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias commented Nov 25, 2016

daviddias commented Nov 25, 2016 • edited Loading

daviddias commented Nov 26, 2016

mafintosh commented Nov 26, 2016

mafintosh commented Nov 26, 2016

daviddias commented Nov 26, 2016

daviddias commented Nov 24, 2016 •

edited

Loading

daviddias commented Nov 25, 2016 •

edited

Loading