This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: files.cat: detect and handle errors when unknown path and cat dir #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tests here: ipfs-inactive/interface-js-ipfs-core#182 |
daviddias
approved these changes
Dec 12, 2017
|
Will wait on ipfs-inactive/interface-js-ipfs-core#183 (review) to release this fix. |
alanshaw
reviewed
Dec 14, 2017
| @@ -137,10 +137,19 @@ module.exports = function files (self) { | |||
| pull.collect((err, files) => { | |||
| if (err) { d.end(err) } | |||
| } | ||
|
|
||
| const content = files[files.length - 1].content | ||
| if (files.length > 1) { | ||
| files = files.filter((file) => file.path === ipfsPath) |
There was a problem hiding this comment.
Here file.path is the path from the root e.g. tour and tour/0.0-intro, and ipfsPath is the full path e.g. /ipfs/QmfGBRT6BbWJd7yUc2uYdaUZJBbnEFvTqehPFoSMQ6wgdr/tour.
This filter is removing all the files from the array and so files[0] below is undefined
There was a problem hiding this comment.
Theres's still an issue here, where "tour" dir is being filtered out prematurely because the output path doesn't match the input. Digging in...
There was a problem hiding this comment.
... which should be fixed f6c15c6
richardschneider
pushed a commit
that referenced
this pull request
Dec 17, 2017
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1142