Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Awesome Endeavour - Correct libp2p-webrtc-star situation #981

Closed
4 tasks done
daviddias opened this issue Sep 3, 2017 · 1 comment
Closed
4 tasks done

Awesome Endeavour - Correct libp2p-webrtc-star situation #981

daviddias opened this issue Sep 3, 2017 · 1 comment
Labels
awesome endeavour

Comments

@daviddias
Copy link
Member

daviddias commented Sep 3, 2017 •
edited
Loading

Following the ☕️💬 between @diasdavid and @lgierth https://github.com/ipfs/pm/pull/492/files#r136710447

  • libp2p-webrtc-star should encapsulate another multiaddr (as described in the issue) and that means that a /libp2p-webrtc-star/dns4/star-signal.cloud.ipfs.team/wss/ipfs/<your-peer-id> should in fact be /dns4/star-signal.cloud.ipfs.team/wss/libp2p-webrtc-star/ipfs/<your-peer-id>. This requires
    • Updating js-mafmt
    • Bubble up all the changes through the dep tree
  • Change libp2p-webrtc-star to p2p-webrtc-star (so that it matches the nomenclature also used by p2p-circuit)
@daviddias daviddias mentioned this issue Sep 3, 2017
Merged
@daviddias daviddias changed the title Awesome Endeavour - Correct libp2p-webrtc-star addrs Awesome Endeavour - Correct libp2p-webrtc-star situation Sep 3, 2017
This was referenced Sep 3, 2017
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
daviddias referenced this issue in ipfs/js-ipfs-bitswap Sep 3, 2017
@daviddias
chore: update deps
d81fc31
@daviddias daviddias mentioned this issue Sep 3, 2017
Merged
@daviddias
Copy link
Member Author

And with #984, this endeavor ends!

@daviddias daviddias mentioned this issue Sep 4, 2017
Closed
@daviddias daviddias mentioned this issue Sep 11, 2017
Closed
16 tasks
@snyk-bot snyk-bot mentioned this issue Mar 29, 2021
Open
@rtpro rtpro mentioned this issue Jun 21, 2023
Open
This was referenced Jul 7, 2023
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
awesome endeavour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daviddias