This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
ipfs-core-types causes problems when isolateModules flag is set #3494
Assignees
Labels
status/ready
Ready to be worked
Comments
|
In the linked thread you say you've worked around the issue - is this still valid? |
|
Ah, I guess #3495 is the work around? |
achingbrain
pushed a commit
that referenced
this issue
Jan 22, 2021
Fixes #3494 Fixes #3498 It appears that `react-scripts` swaps `isolateModules` which [causes problems in webui](ipfs/ipfs-webui#1655 (comment)) because according to TS: > Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'. TS1205 Changes here address that problem as follows: - `export type {...}` is used as per TS error. - `isolateModules` flag is set to `true` so that such issues can be caught locally. - Setting flags seems to have triggered problems in `ipfs-client`, so I had to add some type annotations to fix that. - Added `references` in `ipfs-client/tsconfig.json`, otherwise it does not pick up changes in the dependencies unless they are manually rebuild.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See following issue for the context ipfs/ipfs-webui#1655 (comment)
The text was updated successfully, but these errors were encountered: