This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: add support for ipns and recursive to ipfs resolve #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
reviewed
Jul 26, 2019
hugomrdias
force-pushed
the
feat/resolve-ipns-recursive
branch
from
1561255
to
fc76875
Compare
alanshaw
suggested changes
Aug 2, 2019
| @@ -74,7 +74,6 @@ | |||
| "bs58": "^4.0.1", | |||
| "buffer-peek-stream": "^1.0.1", | |||
| "byteman": "^1.3.5", | |||
| "callbackify": "^1.1.0", | |||
There was a problem hiding this comment.
callbackify is used here https://github.com/ipfs/js-ipfs/blob/813048ffb32a11cfefc51c2ec8634faaff2a924e/src/core/components/files-mfs.js so will need to be migrated to promise-nodeify. Would be rad if you also migrated libp2p-kad-dht 😉🙏:
ipfs@0.37.0-rc.0 /Users/alan/Code/pl/ipfs/js-ipfs
├── callbackify@1.1.0
└─┬ libp2p-kad-dht@0.15.3
└── callbackify@1.1.0 deduped
1 task
|
BREAKING CHANGE: |
|
@hugomrdias 🙏 please can we have this one fixed up? |
hugomrdias
force-pushed
the
feat/resolve-ipns-recursive
branch
2 times, most recently
from
57db3aa
to
41d2749
Compare
alanshaw
approved these changes
Sep 3, 2019
alanshaw
suggested changes
Sep 3, 2019
There was a problem hiding this comment.
Can you please unskip the resolve with IPNS interface tests?
js-ipfs/test/core/interface.spec.js
Lines 98 to 105 in 41d2749
|
blocked by #2416 |
alanshaw
removed
the
status/blocked
|
Ok, DNS on ipfs.io has been fixed - @hugomrdias can you fix up the other test failures please? 🙏 |
This PR add IPNS support to resolve, makes the recursive option true by default and reworks the tests. Jsdocs were add to the resolve methods. Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet needs: ipfs-inactive/interface-js-ipfs-core#504
the api docs doesn't have this options so it's best to remove and simplify the logic
hugomrdias
force-pushed
the
feat/resolve-ipns-recursive
branch
from
a9d5bc0
to
1e40992
Compare
|
ready |
alanshaw
approved these changes
Sep 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds IPNS support to resolve, makes the recursive option true by default and reworks the tests.
Jsdocs were added to the resolve method.
Two interface-core config profile tests needed to be skipped because js-ipfs doesn't support them yet
ref:
#2000